Browse Source

fix(rn,JingleSessionPC) remove aggressive layer suspension in RN

It's possible we get sender constraint messages while operations to
change the direction in the JVB session are in progress so we currently
have no predictable way to properly suspend video without races.

Since this will be solved when we move to transceivers, this is a
compromise we are making.
dev1
Saúl Ibarra Corretgé 3 years ago
parent
commit
a8e3a57489
1 changed files with 0 additions and 9 deletions
  1. 0
    9
      modules/xmpp/JingleSessionPC.js

+ 0
- 9
modules/xmpp/JingleSessionPC.js View File

1514
         if (this._assertNotEnded()) {
1514
         if (this._assertNotEnded()) {
1515
             logger.info(`${this} setSenderVideoConstraint: ${maxFrameHeight}, sourceName: ${sourceName}`);
1515
             logger.info(`${this} setSenderVideoConstraint: ${maxFrameHeight}, sourceName: ${sourceName}`);
1516
 
1516
 
1517
-            // RN doesn't support RTCRtpSenders yet, aggresive layer suspension on RN is implemented
1518
-            // by changing the media direction in the SDP. This is applicable to jvb sessions only.
1519
-            if (!this.isP2P && browser.isReactNative() && typeof maxFrameHeight !== 'undefined') {
1520
-                const audioActive = this.peerconnection.audioTransferActive;
1521
-                const videoActive = this.peerconnection.videoTransferActive && maxFrameHeight > 0;
1522
-
1523
-                return this.setMediaTransferActive(audioActive, videoActive);
1524
-            }
1525
-
1526
             const jitsiLocalTrack = sourceName
1517
             const jitsiLocalTrack = sourceName
1527
                 ? this.rtc.getLocalVideoTracks().find(track => track.getSourceName() === sourceName)
1518
                 ? this.rtc.getLocalVideoTracks().find(track => track.getSourceName() === sourceName)
1528
                 : this.rtc.getLocalVideoTrack();
1519
                 : this.rtc.getLocalVideoTrack();

Loading…
Cancel
Save