fix: Fix unit tests for PerformanceObserverStats

modules/statistics/PerformanceObserverStats.js

@@ -24,7 +24,7 @@ export class PerformanceObserverStats {
     constructor(emitter, statsInterval) {
         this.eventEmitter = emitter;
         this.longTasks = 0;
-        this.maxTaskDuration = 0;
+        this.maxDuration = 0;
         this.performanceStatsInterval = statsInterval;
         this.stats = new RunningAverage();
     }
@@ -34,10 +34,10 @@ export class PerformanceObserverStats {
      * duration of the longest task recorded by the observer.
      * @returns {Object}
      */
-    getPerformanceStats() {
+    getLongTasksStats() {
         return {
             average: (this.stats.getAverage() * SECONDS).toFixed(2), // calc rate per min
-            maxTaskDuration: this.maxTaskDuration
+            maxDuration: this.maxDuration
         };
     }
 
@@ -53,7 +53,7 @@ export class PerformanceObserverStats {
 
             for (const task of entries) {
                 this.longTasks++;
-                this.maxTaskDuration = Math.max(this.maxTaskDuration, task.duration).toFixed(3);
+                this.maxDuration = Math.max(this.maxDuration, task.duration).toFixed(3);
             }
         };
 
@@ -74,7 +74,7 @@ export class PerformanceObserverStats {
 
             this.stats.addNext(rate);
             this.eventEmitter.emit(
-                StatisticsEvents.LONG_TASKS_STATS, this.getPerformanceStats());
+                StatisticsEvents.LONG_TASKS_STATS, this.getLongTasksStats());
 
             // Reset the counter and start counting events again.
             this.longTasks = 0;

modules/statistics/PerformanceObserverStats.spec.js

@@ -1,47 +1,67 @@
-import EventEmitter from 'events';
 
-import JitsiConference from '../../JitsiConference';
 import * as JitsiConferenceEvents from '../../JitsiConferenceEvents';
 import browser from '../browser';
+import Listenable from '../util/Listenable';
 
 import Statistics from './statistics';
 
 /**
  * Mock object to be used in place of a real conference.
  *
- * @constructor
  */
-function MockConference() {
-    this.eventEmitter = new EventEmitter();
+class MockConference extends Listenable {
+    /**
+     * constructor
+     */
+    constructor() {
+        super();
+        this.options = {
+            config: {}
+        };
+    }
 }
-MockConference.prototype = Object.create(JitsiConference.prototype);
-MockConference.prototype.constructor = JitsiConference;
 
 describe('PerformanceObserverStats', () => {
+    let mockConference, statistics;
+
     beforeEach(() => {
         // works only on chrome.
         spyOn(browser, 'isChrome').and.returnValue(true);
+        mockConference = new MockConference();
+        Statistics.init({ longTasksStatsInterval: 1000 });
+        statistics = new Statistics();
+        jasmine.clock().install();
     });
 
-    it('Emits performance stats every sec', () => {
-        const mockConference = new MockConference();
-        const statistics = new Statistics();
-
+    it('Conference events start/stop observer', () => {
         statistics.attachLongTasksStats(mockConference);
-
         const startObserverSpy = spyOn(statistics.performanceObserverStats, 'startObserver');
         const stopObserverSpy = spyOn(statistics.performanceObserverStats, 'stopObserver');
-        const addNextSpy = spyOn(statistics.performanceObserverStats.stats, 'addNext');
 
         mockConference.eventEmitter.emit(JitsiConferenceEvents.CONFERENCE_JOINED);
         expect(startObserverSpy).toHaveBeenCalled();
-        expect(statistics.performanceObserverStats.getLongTasksStats()).toBeTruthy();
-
-        setTimeout(() => {
-            expect(addNextSpy).toHaveBeenCalled();
-        }, 1000);
 
         mockConference.eventEmitter.emit(JitsiConferenceEvents.CONFERENCE_LEFT);
         expect(stopObserverSpy).toHaveBeenCalled();
     });
+
+    it('Emits long tasks stats every sec', () => {
+        statistics.attachLongTasksStats(mockConference);
+        statistics.performanceObserverStats.eventEmitter = {
+            // eslint-disable-next-line no-empty-function
+            emit: () => {}
+        };
+        statistics.performanceObserverStats.startObserver();
+        const eventEmitSpy = spyOn(statistics.performanceObserverStats.eventEmitter, 'emit');
+
+        expect(statistics.performanceObserverStats.getLongTasksStats()).toBeTruthy();
+        expect(eventEmitSpy).not.toHaveBeenCalled();
+
+        jasmine.clock().tick(1000);
+        expect(eventEmitSpy).toHaveBeenCalled();
+    });
+
+    afterEach(() => {
+        jasmine.clock().uninstall();
+    });
 });