e2ee: remove legacy apis (#1653)

remove legacy APIs which are not even supported anymore

modules/RTC/RTC.js

@@ -473,8 +473,6 @@ export default class RTC extends Listenable {
         if (options.enableInsertableStreams) {
             logger.debug('E2EE - setting insertable streams constraints');
             iceConfig.encodedInsertableStreams = true;
-            iceConfig.forceEncodedAudioInsertableStreams = true; // legacy, to be removed in M88.
-            iceConfig.forceEncodedVideoInsertableStreams = true; // legacy, to be removed in M88.
         }
 
         const supportsSdpSemantics = browser.isReactNative()

modules/browser/BrowserCapabilities.js

@@ -241,8 +241,7 @@ export default class BrowserCapabilities extends BrowserDetection {
      */
     supportsInsertableStreams() {
         if (!(typeof window.RTCRtpSender !== 'undefined'
-            && (window.RTCRtpSender.prototype.createEncodedStreams
-                || window.RTCRtpSender.prototype.createEncodedVideoStreams))) {
+            && window.RTCRtpSender.prototype.createEncodedStreams)) {
             return false;
         }
 

modules/e2ee/E2EEContext.js

@@ -74,22 +74,14 @@ export default class E2EEcontext {
         }
         receiver[kJitsiE2EE] = true;
 
-        let receiverStreams;
-
-        if (receiver.createEncodedStreams) {
-            receiverStreams = receiver.createEncodedStreams();
-        } else {
-            receiverStreams = kind === 'video' ? receiver.createEncodedVideoStreams()
-                : receiver.createEncodedAudioStreams();
-        }
+        const receiverStreams = receiver.createEncodedStreams();
 
         this._worker.postMessage({
             operation: 'decode',
-            readableStream: receiverStreams.readable || receiverStreams.readableStream,
-            writableStream: receiverStreams.writable || receiverStreams.writableStream,
+            readableStream: receiverStreams.readable,
+            writableStream: receiverStreams.writable,
             participantId
-        }, [ receiverStreams.readable || receiverStreams.readableStream,
-            receiverStreams.writable || receiverStreams.writableStream ]);
+        }, [ receiverStreams.readable, receiverStreams.writable ]);
     }
 
     /**
@@ -106,22 +98,14 @@ export default class E2EEcontext {
         }
         sender[kJitsiE2EE] = true;
 
-        let senderStreams;
-
-        if (sender.createEncodedStreams) {
-            senderStreams = sender.createEncodedStreams();
-        } else {
-            senderStreams = kind === 'video' ? sender.createEncodedVideoStreams()
-                : sender.createEncodedAudioStreams();
-        }
+        const senderStreams = sender.createEncodedStreams();
 
         this._worker.postMessage({
             operation: 'encode',
-            readableStream: senderStreams.readable || senderStreams.readableStream,
-            writableStream: senderStreams.writable || senderStreams.writableStream,
+            readableStream: senderStreams.readable,
+            writableStream: senderStreams.writable,
             participantId
-        }, [ senderStreams.readable || senderStreams.readableStream,
-            senderStreams.writable || senderStreams.writableStream ]);
+        }, [ senderStreams.readable, senderStreams.writable ]);
     }
 
     /**

modules/e2ee/Worker.js

@@ -4,7 +4,6 @@
 // Worker for E2EE/Insertable streams.
 
 import { Context } from './Context';
-import { polyFillEncodedFrameMetadata } from './utils';
 
 const contexts = new Map(); // Map participant id => context
 
@@ -23,9 +22,6 @@ onmessage = async event => {
         });
 
         readableStream
-            .pipeThrough(new TransformStream({
-                transform: polyFillEncodedFrameMetadata // M83 polyfill.
-            }))
             .pipeThrough(transformStream)
             .pipeTo(writableStream);
     } else if (operation === 'decode') {
@@ -40,9 +36,6 @@ onmessage = async event => {
         });
 
         readableStream
-            .pipeThrough(new TransformStream({
-                transform: polyFillEncodedFrameMetadata // M83 polyfill.
-            }))
             .pipeThrough(transformStream)
             .pipeTo(writableStream);
     } else if (operation === 'setKey') {

modules/e2ee/utils.js

@@ -1,22 +1,3 @@
-/**
- * Polyfill RTCEncoded(Audio|Video)Frame.getMetadata() (not available in M83, available M84+).
- * The polyfill can not be done on the prototype since its not exposed in workers. Instead,
- * it is done as another transformation to keep it separate.
- * TODO: remove when we decode to drop M83 support.
- */
-export function polyFillEncodedFrameMetadata(encodedFrame, controller) {
-    if (!encodedFrame.getMetadata) {
-        encodedFrame.getMetadata = function() {
-            return {
-                // TODO: provide a more complete polyfill based on additionalData for video.
-                synchronizationSource: this.synchronizationSource,
-                contributingSources: this.contributingSources
-            };
-        };
-    }
-    controller.enqueue(encodedFrame);
-}
-
 /**
  * Compares two byteArrays for equality.
  */