Implement review changes 3

modules/RTC/RTCUtils.js

@@ -415,10 +415,10 @@ function newGetConstraints(um = [], options = {}) {
         }
 
         constraints.audio = {
-            autoGainControl: { exact: !disableAGC && !disableAP },
+            autoGainControl: !disableAGC && !disableAP,
             deviceId: options.micDeviceId,
-            echoCancellation: { exact: !disableAEC && !disableAP },
-            noiseSuppression: { exact: !disableNS && !disableAP }
+            echoCancellation: !disableAEC && !disableAP,
+            noiseSuppression: !disableNS && !disableAP
         };
 
         if (stereo) {

modules/RTC/ScreenObtainer.js

@@ -163,13 +163,12 @@ const ScreenObtainer = {
             getDisplayMedia = navigator.mediaDevices.getDisplayMedia.bind(navigator.mediaDevices);
         }
 
-        const { disableAGC, disableAP, enableHdAudio } = this.options;
-        const audioProcessingValue = !disableAGC && !disableAP;
-        const audio = enableHdAudio ? {
-            autoGainControl: audioProcessingValue,
+        const { stereo } = this.options;
+        const audio = stereo ? {
+            autoGainControl: false,
             channelCount: 2,
-            echoCancellation: audioProcessingValue,
-            noiseSuppression: audioProcessingValue
+            echoCancellation: false,
+            noiseSuppression: false
         } : true;
 
         getDisplayMedia({

modules/RTC/TraceablePeerConnection.js

@@ -2157,6 +2157,12 @@ TraceablePeerConnection.prototype._adjustLocalMediaDirection = function(
  * @returns {RTCSessionDescription} the munged description.
  */
 TraceablePeerConnection.prototype._mungeOpus = function(description) {
+    const { opusMaxAverageBitrate, stereo } = this.options;
+
+    if (!opusMaxAverageBitrate || !stereo) {
+        return description;
+    }
+
     const parsedSdp = transform.parse(description.sdp);
     const mLines = parsedSdp.media;
 
@@ -2180,13 +2186,13 @@ TraceablePeerConnection.prototype._mungeOpus = function(description) {
             const fmtpConfig = transform.parseParams(fmtpOpus.config);
             let sdpChanged = false;
 
-            if (this.options.stereo) {
+            if (stereo) {
                 fmtpConfig.stereo = 1;
                 sdpChanged = true;
             }
 
-            if (this.options.opusMaxAverageBitrate) {
-                fmtpConfig.opusMaxAverageBitrate = this.options.opusMaxAverageBitrate;
+            if (opusMaxAverageBitrate) {
+                fmtpConfig.opusMaxAverageBitrate = opusMaxAverageBitrate;
                 sdpChanged = true;
             }