浏览代码

fix(audio-levels) check if local stats are supported before starting stats collection.

master
Jaya Allamsetty 2 年前
父节点
当前提交
c8d76d4ad7
共有 3 个文件被更改,包括 5 次插入5 次删除
  1. 2
    1
      JitsiConference.js
  2. 2
    3
      JitsiMeetJS.ts
  3. 1
    1
      modules/statistics/LocalStatsCollector.js

+ 2
- 1
JitsiConference.js 查看文件

35
 import Settings from './modules/settings/Settings';
35
 import Settings from './modules/settings/Settings';
36
 import AudioOutputProblemDetector from './modules/statistics/AudioOutputProblemDetector';
36
 import AudioOutputProblemDetector from './modules/statistics/AudioOutputProblemDetector';
37
 import AvgRTPStatsReporter from './modules/statistics/AvgRTPStatsReporter';
37
 import AvgRTPStatsReporter from './modules/statistics/AvgRTPStatsReporter';
38
+import LocalStatsCollector from './modules/statistics/LocalStatsCollector';
38
 import SpeakerStatsCollector from './modules/statistics/SpeakerStatsCollector';
39
 import SpeakerStatsCollector from './modules/statistics/SpeakerStatsCollector';
39
 import Statistics from './modules/statistics/statistics';
40
 import Statistics from './modules/statistics/statistics';
40
 import Transcriber from './modules/transcription/transcriber';
41
 import Transcriber from './modules/transcription/transcriber';
531
     }
532
     }
532
 
533
 
533
     // Generates events based on no audio input detector.
534
     // Generates events based on no audio input detector.
534
-    if (config.enableNoAudioDetection && !config.disableAudioLevels) {
535
+    if (config.enableNoAudioDetection && !config.disableAudioLevels && LocalStatsCollector.isLocalStatsSupported()) {
535
         this._noAudioSignalDetection = new NoAudioSignalDetection(this);
536
         this._noAudioSignalDetection = new NoAudioSignalDetection(this);
536
         this._noAudioSignalDetection.on(DetectionEvents.NO_AUDIO_INPUT, () => {
537
         this._noAudioSignalDetection.on(DetectionEvents.NO_AUDIO_INPUT, () => {
537
             this.eventEmitter.emit(JitsiConferenceEvents.NO_AUDIO_INPUT);
538
             this.eventEmitter.emit(JitsiConferenceEvents.NO_AUDIO_INPUT);

+ 2
- 3
JitsiMeetJS.ts 查看文件

307
                         'success',
307
                         'success',
308
                         getAnalyticsAttributesFromOptions(restOptions)));
308
                         getAnalyticsAttributesFromOptions(restOptions)));
309
 
309
 
310
-                if (!RTC.options.disableAudioLevels) {
310
+                if (this.isCollectingLocalStats()) {
311
                     for (let i = 0; i < tracks.length; i++) {
311
                     for (let i = 0; i < tracks.length; i++) {
312
                         const track = tracks[i];
312
                         const track = tracks[i];
313
 
313
 
484
      * @param {boolean} True if stats are being collected for local tracks.
484
      * @param {boolean} True if stats are being collected for local tracks.
485
      */
485
      */
486
     isCollectingLocalStats() {
486
     isCollectingLocalStats() {
487
-        return Statistics.audioLevelsEnabled
488
-            && LocalStatsCollector.isLocalStatsSupported();
487
+        return Statistics.audioLevelsEnabled && LocalStatsCollector.isLocalStatsSupported();
489
     },
488
     },
490
 
489
 
491
     /**
490
     /**

+ 1
- 1
modules/statistics/LocalStatsCollector.js 查看文件

143
  * @returns {boolean}
143
  * @returns {boolean}
144
  */
144
  */
145
 LocalStatsCollector.isLocalStatsSupported = function() {
145
 LocalStatsCollector.isLocalStatsSupported = function() {
146
-    return Boolean(window.AudioContext);
146
+    return Boolean(window?.AudioContext);
147
 };
147
 };
148
 
148
 
149
 /**
149
 /**

正在加载...
取消
保存