Pārlūkot izejas kodu

ref(TPC): Cleanup flags related to low fps screenshare.

Simulcast for SS is always on in unified plan mode, the lower spatial resolution streams are turned off for low fps sharing.
dev1
Jaya Allamsetty 2 gadus atpakaļ
vecāks
revīzija
ca3e361186

+ 1
- 1
modules/RTC/TraceablePeerConnection.js Parādīt failu

244
     this.statsinterval = null;
244
     this.statsinterval = null;
245
 
245
 
246
     /**
246
     /**
247
-     * Flag used to indicate if simulcast is turned off and a cap of 500 Kbps is applied on screensharing.
247
+     * Flag used to indicate if low fps screenshare is desired.
248
      */
248
      */
249
     this._capScreenshareBitrate = this.options.capScreenshareBitrate;
249
     this._capScreenshareBitrate = this.options.capScreenshareBitrate;
250
 
250
 

+ 1
- 6
modules/xmpp/JingleSessionPC.js Parādīt failu

446
             pcOptions.disableSimulcast
446
             pcOptions.disableSimulcast
447
                 = options.disableSimulcast || options.videoQuality?.preferredCodec === CodecMimeType.H264;
447
                 = options.disableSimulcast || options.videoQuality?.preferredCodec === CodecMimeType.H264;
448
 
448
 
449
-            // Disable simulcast for low fps screenshare and enable it for high fps screenshare.
450
-            // testing.capScreenshareBitrate config.js setting has now been deprecated.
449
+            // Do not send lower spatial layers for low fps screenshare and enable them only for high fps screenshare.
451
             pcOptions.capScreenshareBitrate = pcOptions.disableSimulcast
450
             pcOptions.capScreenshareBitrate = pcOptions.disableSimulcast
452
                 || !(typeof options.desktopSharingFrameRate?.max === 'number'
451
                 || !(typeof options.desktopSharingFrameRate?.max === 'number'
453
                     && options.desktopSharingFrameRate?.max > SS_DEFAULT_FRAME_RATE);
452
                     && options.desktopSharingFrameRate?.max > SS_DEFAULT_FRAME_RATE);
454
-
455
-            // add the capScreenshareBitrate to the permanent properties so that it's included with every event that we
456
-            // send to the analytics backend.
457
-            Statistics.analytics.addPermanentProperties({ capScreenshareBitrate: pcOptions.capScreenshareBitrate });
458
         }
453
         }
459
 
454
 
460
         if (options.startSilent) {
455
         if (options.startSilent) {

Notiek ielāde…
Atcelt
Saglabāt