Procházet zdrojové kódy

feat(BridgeChannel): don't log channel objects

They are really verbose, and add no real value. In addition, log the channel
type once opened.
dev1
Saúl Ibarra Corretgé před 8 roky
rodič
revize
dcb6c14dfe
1 změnil soubory, kde provedl 4 přidání a 4 odebrání
  1. 4
    4
      modules/RTC/BridgeChannel.js

+ 4
- 4
modules/RTC/BridgeChannel.js Zobrazit soubor

@@ -176,7 +176,7 @@ export default class BridgeChannel {
176 176
         const emitter = this._eventEmitter;
177 177
 
178 178
         channel.onopen = () => {
179
-            logger.info('Channel opened by the Videobridge!', channel);
179
+            logger.info(`${this._mode} channel opened`);
180 180
 
181 181
             // Code sample for sending string and/or binary data.
182 182
             // Sends string message to the bridge:
@@ -188,7 +188,7 @@ export default class BridgeChannel {
188 188
         };
189 189
 
190 190
         channel.onerror = error => {
191
-            logger.error('Channel error:', error, channel);
191
+            logger.error('Channel error:', error);
192 192
         };
193 193
 
194 194
         channel.onmessage = ({ data }) => {
@@ -201,7 +201,7 @@ export default class BridgeChannel {
201 201
                 GlobalOnErrorHandler.callErrorHandler(error);
202 202
                 logger.error(
203 203
                     'Failed to parse channel message as JSON: ',
204
-                    data, channel, error);
204
+                    data, error);
205 205
 
206 206
                 return;
207 207
             }
@@ -264,7 +264,7 @@ export default class BridgeChannel {
264 264
         };
265 265
 
266 266
         channel.onclose = () => {
267
-            logger.info('Channel closed', channel);
267
+            logger.info('Channel closed');
268 268
 
269 269
             // Remove the channel.
270 270
             this._channel = null;

Načítá se…
Zrušit
Uložit