浏览代码

address code review

dev1
Andrei Gavrilescu 6 年前
父节点
当前提交
e2d029e5c7
共有 2 个文件被更改,包括 1 次插入6 次删除
  1. 1
    4
      JitsiConference.js
  2. 0
    2
      webpack.config.js

+ 1
- 4
JitsiConference.js 查看文件

379
         // based detection.
379
         // based detection.
380
         if (config.createVADProcessor) {
380
         if (config.createVADProcessor) {
381
             logger.info('Using VAD detection for generating talk while muted events');
381
             logger.info('Using VAD detection for generating talk while muted events');
382
-            // eslint-disable-next-line no-new
383
             this._talkWhileMutedDetection = new VADTalkMutedDetection(this, config.createVADProcessor);
382
             this._talkWhileMutedDetection = new VADTalkMutedDetection(this, config.createVADProcessor);
384
             this._talkWhileMutedDetection.on(DetectionEvents.VAD_TALK_WHILE_MUTED, () =>
383
             this._talkWhileMutedDetection.on(DetectionEvents.VAD_TALK_WHILE_MUTED, () =>
385
                 this.eventEmitter.emit(JitsiConferenceEvents.TALK_WHILE_MUTED));
384
                 this.eventEmitter.emit(JitsiConferenceEvents.TALK_WHILE_MUTED));
392
     }
391
     }
393
 
392
 
394
     // Generates events based on no audio input detector.
393
     // Generates events based on no audio input detector.
395
-    // eslint-disable-next-line
396
     if (config.enableNoAudioDetection) {
394
     if (config.enableNoAudioDetection) {
397
-        // eslint-disable-next-line no-new
398
-        new NoAudioSignalDetection(this, () =>
395
+        this._noAudioSignalDetection = new NoAudioSignalDetection(this, () =>
399
             this.eventEmitter.emit(JitsiConferenceEvents.NO_AUDIO_INPUT));
396
             this.eventEmitter.emit(JitsiConferenceEvents.NO_AUDIO_INPUT));
400
     }
397
     }
401
 
398
 

+ 0
- 2
webpack.config.js 查看文件

61
         concatenateModules: minimize
61
         concatenateModules: minimize
62
     },
62
     },
63
     output: {
63
     output: {
64
-        // eslint-disable-next-line
65
         filename: `[name]${minimize ? '.min' : ''}.js`,
64
         filename: `[name]${minimize ? '.min' : ''}.js`,
66
         path: process.cwd(),
65
         path: process.cwd(),
67
-        // eslint-disable-next-line
68
         sourceMapFilename: `[name].${minimize ? 'min' : 'js'}.map`
66
         sourceMapFilename: `[name].${minimize ? 'min' : 'js'}.map`
69
     },
67
     },
70
     performance: {
68
     performance: {

正在加载...
取消
保存