fix(eslint): Add eqeqeq rule

.eslintrc.js

@@ -76,6 +76,7 @@ module.exports = {
         'default-case': 0,
         'dot-location': [ 'error', 'property' ],
         'dot-notation': 2,
+        'eqeqeq': 2,
         'guard-for-in': 2,
         'no-alert': 2,
         'no-caller': 2,

JitsiConferenceEventManager.js

@@ -332,12 +332,12 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
 
     chatRoom.addPresenceListener('videomuted', (values, from) => {
         conference.rtc.handleRemoteTrackMute(MediaType.VIDEO,
-            values.value == 'true', from);
+            values.value === 'true', from);
     });
 
     chatRoom.addPresenceListener('audiomuted', (values, from) => {
         conference.rtc.handleRemoteTrackMute(MediaType.AUDIO,
-            values.value == 'true', from);
+            values.value === 'true', from);
     });
 
     chatRoom.addPresenceListener('videoType', (data, from) => {
@@ -575,7 +575,7 @@ JitsiConferenceEventManager.prototype.setupStatisticsListeners = function() {
             const resolution = ssrc2resolution[ssrc];
 
             if (!resolution.width || !resolution.height
-                || resolution.width == -1 || resolution.height == -1) {
+                || resolution.width === -1 || resolution.height === -1) {
                 return;
             }
 

doc/example/example.js

@@ -43,7 +43,7 @@ function onLocalTracks(tracks) {
             deviceId =>
                 console.log(
                     `track audio output device was changed to ${deviceId}`));
-        if (localTracks[i].getType() == 'video') {
+        if (localTracks[i].getType() === 'video') {
             $('body').append(`<video autoplay='1' id='localVideo${i}' />`);
             localTracks[i].attach($(`#localVideo${i}`)[0]);
         } else {
@@ -87,7 +87,7 @@ function onRemoteTrack(track) {
                 `track audio output device was changed to ${deviceId}`));
     const id = participant + track.getType() + idx;
 
-    if (track.getType() == 'video') {
+    if (track.getType() === 'video') {
         $('body').append(
             `<video autoplay='1' id='${participant}video${idx}' />`);
     } else {

modules/RTC/DataChannels.js

@@ -266,7 +266,7 @@ DataChannels.prototype._some = function(callback, thisArg) {
  */
 DataChannels.prototype.send = function(jsonObject) {
     if (!this._some(dataChannel => {
-        if (dataChannel.readyState == 'open') {
+        if (dataChannel.readyState === 'open') {
             dataChannel.send(JSON.stringify(jsonObject));
 
             return true;

modules/RTC/RTC.js

@@ -486,8 +486,8 @@ export default class RTC extends Listenable {
                     const mediaTrack = endpointTracks[mediaType];
 
                     if (mediaTrack
-                        && mediaTrack.getStreamId() == streamId
-                        && mediaTrack.getTrackId() == trackId) {
+                        && mediaTrack.getStreamId() === streamId
+                        && mediaTrack.getTrackId() === trackId) {
                         result = mediaTrack;
 
                         return true;
@@ -680,7 +680,12 @@ export default class RTC extends Listenable {
      * @param ssrc the ssrc to check.
      */
     getResourceBySSRC(ssrc) {
+
+        // FIXME: Convert the SSRCs in whole project to use the same type.
+        // Now we are using number and string.
         if (this.getLocalTracks().find(
+
+            // eslint-disable-next-line eqeqeq
                 localTrack => localTrack.getSSRC() == ssrc)) {
             return this.conference.myUserId();
         }
@@ -699,6 +704,10 @@ export default class RTC extends Listenable {
      * matches given SSRC or <tt>undefined</tt> if no such track was found.
      */
     getRemoteTrackBySSRC(ssrc) {
+
+        // FIXME: Convert the SSRCs in whole project to use the same type.
+        // Now we are using number and string.
+        // eslint-disable-next-line eqeqeq
         return this.getRemoteTracks().find(t => ssrc == t.getSSRC());
     }
 

modules/RTC/RTCBrowserType.js

@@ -377,6 +377,6 @@ function detectBrowser() {
 }
 
 const browserVersion = detectBrowser();
-const isAndroid = navigator.userAgent.indexOf('Android') != -1;
+const isAndroid = navigator.userAgent.indexOf('Android') !== -1;
 
 module.exports = RTCBrowserType;

modules/RTC/RTCUtils.js

@@ -328,10 +328,10 @@ function setAvailableDevices(um, stream) {
     const audioTracksReceived = stream && stream.getAudioTracks().length > 0;
     const videoTracksReceived = stream && stream.getVideoTracks().length > 0;
 
-    if (um.indexOf('video') != -1) {
+    if (um.indexOf('video') !== -1) {
         devices.video = videoTracksReceived;
     }
-    if (um.indexOf('audio') != -1) {
+    if (um.indexOf('audio') !== -1) {
         devices.audio = audioTracksReceived;
     }
 

modules/RTC/ScreenObtainer.js

@@ -103,7 +103,7 @@ const ScreenObtainer = {
                         // but this is what we are receiving from GUM when the
                         // streamId for the desktop sharing is "".
 
-                        if (error && error.name == 'InvalidStateError') {
+                        if (error && error.name === 'InvalidStateError') {
                             jitsiError = new JitsiTrackError(
                                 JitsiTrackErrors.CHROME_EXTENSION_USER_CANCELED
                             );

modules/RTC/TraceablePeerConnection.js

@@ -862,7 +862,7 @@ const _fixAnswerRFC4145Setup = function(offer, answer) {
     // default choice of setup:active to setup:passive.
     if (offer && answer
             && offer.media && answer.media
-            && offer.media.length == answer.media.length) {
+            && offer.media.length === answer.media.length) {
         answer.media.forEach((a, i) => {
             if (SDPUtil.find_line(
                     offer.media[i],

modules/connectivity/ConnectionQuality.js

@@ -92,7 +92,7 @@ function getTarget(simulcast, resolution, millisSinceStart) {
                 const targetHeight = height;
 
                 simulcastFormat
-                    = kSimulcastFormats.find(f => f.height == targetHeight);
+                    = kSimulcastFormats.find(f => f.height === targetHeight);
                 if (simulcastFormat) {
                     target += simulcastFormat.target;
                 } else {

modules/settings/Settings.js

@@ -10,8 +10,7 @@ import UsernameGenerator from '../util/UsernameGenerator';
  * @returns {Storage} the local Storage object (if any)
  */
 function getLocalStorage() {
-    const global = typeof window == 'undefined' ? this : window;
-
+    const global = typeof window === 'undefined' ? this : window;
 
     return global.localStorage;
 }

modules/statistics/LocalStatsCollector.js

@@ -120,7 +120,7 @@ LocalStatsCollector.prototype.start = function() {
             analyser.getByteTimeDomainData(array);
             const audioLevel = timeDomainDataToAudioLevel(array);
 
-            if (audioLevel != self.audioLevel) {
+            if (audioLevel !== self.audioLevel) {
                 self.audioLevel = animateLevel(audioLevel, self.audioLevel);
                 self.callback(self.audioLevel);
             }

modules/statistics/RTPStatsCollector.js

@@ -259,7 +259,7 @@ StatsCollector.prototype.start = function(startAudioLevelStats) {
                         let results = null;
 
                         if (!report || !report.result
-                            || typeof report.result != 'function') {
+                            || typeof report.result !== 'function') {
                             results = report;
                         } else {
                             results = report.result();
@@ -285,7 +285,7 @@ StatsCollector.prototype.start = function(startAudioLevelStats) {
                         let results = null;
 
                         if (!report || !report.result
-                            || typeof report.result != 'function') {
+                            || typeof report.result !== 'function') {
                             // firefox
                             results = report;
                         } else {
@@ -429,7 +429,7 @@ StatsCollector.prototype.processStatsReport = function() {
             }
         } catch (e) { /* not supported*/ }
 
-        if (now.type == 'googCandidatePair') {
+        if (now.type === 'googCandidatePair') {
             let active, ip, localip, type;
 
             try {
@@ -438,7 +438,7 @@ StatsCollector.prototype.processStatsReport = function() {
                 localip = getStatValue(now, 'localAddress');
                 active = getStatValue(now, 'activeConnection');
             } catch (e) { /* not supported*/ }
-            if (!ip || !type || !localip || active != 'true') {
+            if (!ip || !type || !localip || active !== 'true') {
                 continue;
             }
 
@@ -447,7 +447,9 @@ StatsCollector.prototype.processStatsReport = function() {
 
             if (!conferenceStatsTransport.some(
                     t =>
-                        t.ip == ip && t.type == type && t.localip == localip)) {
+                        t.ip === ip
+                        && t.type === type
+                        && t.localip === localip)) {
                 conferenceStatsTransport.push({ ip,
                     type,
                     localip });
@@ -455,8 +457,8 @@ StatsCollector.prototype.processStatsReport = function() {
             continue;
         }
 
-        if (now.type == 'candidatepair') {
-            if (now.state == 'succeeded') {
+        if (now.type === 'candidatepair') {
+            if (now.state === 'succeeded') {
                 continue;
             }
 
@@ -470,8 +472,8 @@ StatsCollector.prototype.processStatsReport = function() {
             });
         }
 
-        if (now.type != 'ssrc' && now.type != 'outboundrtp'
-            && now.type != 'inboundrtp') {
+        if (now.type !== 'ssrc' && now.type !== 'outboundrtp'
+            && now.type !== 'inboundrtp') {
             continue;
         }
 
@@ -655,7 +657,7 @@ StatsCollector.prototype.processAudioLevelReport = function() {
 
         const now = this.currentAudioLevelsReport[idx];
 
-        if (now.type != 'ssrc') {
+        if (now.type !== 'ssrc') {
             continue;
         }
 

modules/xmpp/ChatRoom.js

@@ -221,7 +221,7 @@ export default class ChatRoom extends Listenable {
                         .length
                     === 1;
 
-            if (locked != this.locked) {
+            if (locked !== this.locked) {
                 this.eventEmitter.emit(XMPPEvents.MUC_LOCK_CHANGED, locked);
                 this.locked = locked;
             }
@@ -326,9 +326,9 @@ export default class ChatRoom extends Listenable {
             }
         }
 
-        if (from == this.myroomjid) {
+        if (from === this.myroomjid) {
             const newRole
-                = member.affiliation == 'owner' ? member.role : 'none';
+                = member.affiliation === 'owner' ? member.role : 'none';
 
             if (this.role !== newRole) {
                 this.role = newRole;
@@ -366,7 +366,7 @@ export default class ChatRoom extends Listenable {
             // Watch role change:
             const memberOfThis = this.members[from];
 
-            if (memberOfThis.role != member.role) {
+            if (memberOfThis.role !== member.role) {
                 memberOfThis.role = member.role;
                 this.eventEmitter.emit(
                     XMPPEvents.MUC_ROLE_CHANGED, from, member.role);
@@ -614,7 +614,7 @@ export default class ChatRoom extends Listenable {
         const txt = $(msg).find('>body').text();
         const type = msg.getAttribute('type');
 
-        if (type == 'error') {
+        if (type === 'error') {
             this.eventEmitter.emit(XMPPEvents.CHAT_ERROR_RECEIVED,
                 $(msg).find('>text').text(), txt);
 
@@ -648,7 +648,7 @@ export default class ChatRoom extends Listenable {
             }
         }
 
-        if (from == this.roomjid
+        if (from === this.roomjid
                 && $(msg)
                     .find(
                         '>x[xmlns="http://jabber.org/protocol/muc#user"]'

modules/xmpp/JingleSessionPC.js

@@ -143,7 +143,7 @@ export default class JingleSessionPC extends JingleSession {
                         if (this.webrtcIceTcpDisable) {
                             return;
                         }
-                    } else if (protocol == 'udp') {
+                    } else if (protocol === 'udp') {
                         if (this.webrtcIceUdpDisable) {
                             return;
                         }
@@ -288,7 +288,7 @@ export default class JingleSessionPC extends JingleSession {
         const localSDP = new SDP(this.peerconnection.localDescription.sdp);
 
         for (let mid = 0; mid < localSDP.media.length; mid++) {
-            const cands = candidates.filter(el => el.sdpMLineIndex == mid);
+            const cands = candidates.filter(el => el.sdpMLineIndex === mid);
             const mline
                 = SDPUtil.parse_mline(localSDP.media[mid].split('\r\n')[0]);
 
@@ -298,7 +298,7 @@ export default class JingleSessionPC extends JingleSession {
 
                 ice.xmlns = 'urn:xmpp:jingle:transports:ice-udp:1';
                 cand.c('content', {
-                    creator: this.initiator == this.localJid
+                    creator: this.initiator === this.localJid
                                     ? 'initiator' : 'responder',
                     name: cands[0].sdpMid ? cands[0].sdpMid : mline.media
                 }).c('transport', ice);
@@ -510,7 +510,7 @@ export default class JingleSessionPC extends JingleSession {
         }
         localSDP.toJingle(
             accept,
-            this.initiator == this.localJid ? 'initiator' : 'responder',
+            this.initiator === this.localJid ? 'initiator' : 'responder',
             null);
         this.fixJingle(accept);
 
@@ -574,7 +574,7 @@ export default class JingleSessionPC extends JingleSession {
             transportAccept.c('content',
                 {
                     creator:
-                        this.initiator == this.localJid
+                        this.initiator === this.localJid
                             ? 'initiator'
                             : 'responder',
                     name: mline.media
@@ -946,7 +946,7 @@ export default class JingleSessionPC extends JingleSession {
         return new Promise((resolve, reject) => {
             const remoteUfrag = JingleSessionPC.getUfrag(remoteDescription.sdp);
 
-            if (remoteUfrag != this.remoteUfrag) {
+            if (remoteUfrag !== this.remoteUfrag) {
                 this.remoteUfrag = remoteUfrag;
                 this.room.eventEmitter.emit(
                         XMPPEvents.REMOTE_UFRAG_CHANGED, remoteUfrag);
@@ -969,7 +969,7 @@ export default class JingleSessionPC extends JingleSession {
                             const localUfrag
                                 = JingleSessionPC.getUfrag(answer.sdp);
 
-                            if (localUfrag != this.localUfrag) {
+                            if (localUfrag !== this.localUfrag) {
                                 this.localUfrag = localUfrag;
                                 this.room.eventEmitter.emit(
                                         XMPPEvents.LOCAL_UFRAG_CHANGED,

modules/xmpp/SDP.js

@@ -9,7 +9,7 @@ function SDP(sdp) {
     for (let i = 1, length = media.length; i < length; i++) {
         let media_i = `m=${media[i]}`;
 
-        if (i != length - 1) {
+        if (i !== length - 1) {
             media_i += '\r\n';
         }
         media[i] = media_i;
@@ -124,15 +124,15 @@ SDP.prototype.mangle = function() {
         lines = this.media[i].split('\r\n');
         lines.pop(); // remove empty last element
         mline = SDPUtil.parse_mline(lines.shift());
-        if (mline.media != 'audio') {
+        if (mline.media !== 'audio') {
             continue; // eslint-disable-line no-continue
         }
         newdesc = '';
         mline.fmt.length = 0;
         for (j = 0; j < lines.length; j++) {
-            if (lines[j].substr(0, 9) == 'a=rtpmap:') {
+            if (lines[j].substr(0, 9) === 'a=rtpmap:') {
                 rtpmap = SDPUtil.parse_rtpmap(lines[j]);
-                if (rtpmap.name == 'CN' || rtpmap.name == 'ISAC') {
+                if (rtpmap.name === 'CN' || rtpmap.name === 'ISAC') {
                     continue; // eslint-disable-line no-continue
                 }
                 mline.fmt.push(rtpmap.id);
@@ -275,7 +275,7 @@ SDP.prototype.toJingle = function(elem, thecreator) {
                         const idx = line.indexOf(' ');
                         const linessrc = line.substr(0, idx).substr(7);
 
-                        if (linessrc != ssrc) {
+                        if (linessrc !== ssrc) {
                             elem.up();
                             ssrc = linessrc;
                             elem.c('source', { ssrc,
@@ -284,7 +284,7 @@ SDP.prototype.toJingle = function(elem, thecreator) {
                         const kv = line.substr(idx + 1);
 
                         elem.c('parameter');
-                        if (kv.indexOf(':') == -1) {
+                        if (kv.indexOf(':') === -1) {
                             elem.attrs({ name: kv });
                         } else {
                             const k = kv.split(':', 2)[0];
@@ -413,7 +413,7 @@ SDP.prototype.toJingle = function(elem, thecreator) {
         } else if (SDPUtil.find_line(m, 'a=inactive', this.session)) {
             elem.attrs({ senders: 'none' });
         }
-        if (mline.port == '0') {
+        if (mline.port === '0') {
             // estos hack to reject an m-line
             elem.attrs({ senders: 'rejected' });
         }
@@ -521,7 +521,7 @@ SDP.prototype.rtcpFbToJingle = function(mediaindex, elem, payloadtype) {
     lines.forEach(line => {
         const tmp = SDPUtil.parse_rtcpfb(line);
 
-        if (tmp.type == 'trr-int') {
+        if (tmp.type === 'trr-int') {
             elem.c('rtcp-fb-trr-int', {
                 xmlns: 'urn:xmpp:jingle:apps:rtp:rtcp-fb:0',
                 value: tmp.params[0]
@@ -628,7 +628,7 @@ SDP.prototype.jingle2media = function(content) {
     let tmp = { media: desc.attr('media') };
 
     tmp.port = '1';
-    if (content.attr('senders') == 'rejected') {
+    if (content.attr('senders') === 'rejected') {
         // estos hack to reject an m-line.
         tmp.port = '0';
     }

modules/xmpp/SDPDiffer.js

@@ -19,7 +19,7 @@ SDPDiffer.prototype.getNewMedia = function() {
         }
 
         // compare lengths - can save a lot of time
-        if (this.length != array.length) {
+        if (this.length !== array.length) {
             return false;
         }
 
@@ -30,7 +30,7 @@ SDPDiffer.prototype.getNewMedia = function() {
                 if (!this[i].equals(array[i])) {
                     return false;
                 }
-            } else if (this[i] != array[i]) {
+            } else if (this[i] !== array[i]) {
                 // Warning - two different object instances will never be
                 // equal: {x:20} != {x:20}
                 return false;
@@ -81,7 +81,7 @@ SDPDiffer.prototype.getNewMedia = function() {
             for (let i = 0; i < myMedia.ssrcGroups.length; i++) {
                 const mySsrcGroup = myMedia.ssrcGroups[i];
 
-                if (otherSsrcGroup.semantics == mySsrcGroup.semantics
+                if (otherSsrcGroup.semantics === mySsrcGroup.semantics
                     && arrayEquals.apply(otherSsrcGroup.ssrcs,
                                       [ mySsrcGroup.ssrcs ])) {
 
@@ -143,7 +143,7 @@ SDPDiffer.prototype.toJingle = function(modify) {
                 const kv = line.substr(idx + 1);
 
                 modify.c('parameter');
-                if (kv.indexOf(':') == -1) {
+                if (kv.indexOf(':') === -1) {
                     modify.attrs({ name: kv });
                 } else {
                     const nv = kv.split(':', 2);

modules/xmpp/SDPUtil.js

@@ -97,7 +97,8 @@ const SDPUtil = {
             = `a=rtpmap:${el.getAttribute('id')} ${el.getAttribute('name')}/${
                 el.getAttribute('clockrate')}`;
 
-        if (el.getAttribute('channels') && el.getAttribute('channels') != '1') {
+        if (el.getAttribute('channels')
+            && el.getAttribute('channels') !== '1') {
             line += `/${el.getAttribute('channels')}`;
         }
 
@@ -135,7 +136,7 @@ const SDPUtil = {
         for (let i = 0; i < parts.length; i++) {
             let key = parts[i].split('=')[0];
 
-            while (key.length && key[0] == ' ') {
+            while (key.length && key[0] === ' ') {
                 key = key.substring(1);
             }
             const value = parts[i].split('=')[1];
@@ -244,7 +245,7 @@ const SDPUtil = {
         const lines = desc.split('\r\n');
 
         for (let i = 0; i < lines.length; i++) {
-            if (lines[i].substring(0, 7) == 'a=ssrc:') {
+            if (lines[i].substring(0, 7) === 'a=ssrc:') {
                 const idx = lines[i].indexOf(' ');
 
                 data[lines[i].substr(idx + 1).split(':', 2)[0]]
@@ -284,7 +285,7 @@ const SDPUtil = {
         let lines = haystack.split('\r\n');
 
         for (let i = 0; i < lines.length; i++) {
-            if (lines[i].substring(0, needle.length) == needle) {
+            if (lines[i].substring(0, needle.length) === needle) {
                 return lines[i];
             }
         }
@@ -295,7 +296,7 @@ const SDPUtil = {
         // search session part
         lines = sessionpart.split('\r\n');
         for (let j = 0; j < lines.length; j++) {
-            if (lines[j].substring(0, needle.length) == needle) {
+            if (lines[j].substring(0, needle.length) === needle) {
                 return lines[j];
             }
         }
@@ -307,7 +308,7 @@ const SDPUtil = {
         const needles = [];
 
         for (let i = 0; i < lines.length; i++) {
-            if (lines[i].substring(0, needle.length) == needle) {
+            if (lines[i].substring(0, needle.length) === needle) {
                 needles.push(lines[i]);
             }
         }
@@ -318,7 +319,7 @@ const SDPUtil = {
         // search session part
         lines = sessionpart.split('\r\n');
         for (let j = 0; j < lines.length; j++) {
-            if (lines[j].substring(0, needle.length) == needle) {
+            if (lines[j].substring(0, needle.length) === needle) {
                 needles.push(lines[j]);
             }
         }
@@ -333,7 +334,7 @@ const SDPUtil = {
         if (line.indexOf('candidate:') === 0) {
             // eslint-disable-next-line no-param-reassign
             line = `a=${line}`;
-        } else if (line.substring(0, 12) != 'a=candidate:') {
+        } else if (line.substring(0, 12) !== 'a=candidate:') {
             logger.log(
                 'parseCandidate called with a line that is not a candidate'
                     + ' line');
@@ -341,14 +342,14 @@ const SDPUtil = {
 
             return null;
         }
-        if (line.substring(line.length - 2) == '\r\n') { // chomp it
+        if (line.substring(line.length - 2) === '\r\n') { // chomp it
             // eslint-disable-next-line no-param-reassign
             line = line.substring(0, line.length - 2);
         }
         const candidate = {};
         const elems = line.split(' ');
 
-        if (elems[6] != 'typ') {
+        if (elems[6] !== 'typ') {
             logger.log('did not find typ in the right place');
             logger.log(line);
 
@@ -403,7 +404,7 @@ const SDPUtil = {
 
         // use tcp candidates for FF
 
-        if (RTCBrowserType.isFirefox() && protocol.toLowerCase() == 'ssltcp') {
+        if (RTCBrowserType.isFirefox() && protocol.toLowerCase() === 'ssltcp') {
             protocol = 'tcp';
         }
 
@@ -435,7 +436,7 @@ const SDPUtil = {
             }
             break;
         }
-        if (protocol.toLowerCase() == 'tcp') {
+        if (protocol.toLowerCase() === 'tcp') {
             line += 'tcptype';
             line += ' ';
             line += cand.getAttribute('tcptype');

modules/xmpp/SdpTransformUtil.js

@@ -163,7 +163,7 @@ class MLineWrap {
      */
     getSSRCAttrValue(ssrcNumber, attrName) {
         const attribute = this._ssrcs.find(
-            ssrcObj => ssrcObj.id == ssrcNumber
+            ssrcObj => ssrcObj.id === ssrcNumber
             && ssrcObj.attribute === attrName);
 
 

modules/xmpp/recording.js

@@ -69,7 +69,7 @@ Recording.prototype.handleJibriPresence = function(jibri) {
 
     if (newState === 'undefined') {
         this.state = Recording.status.UNAVAILABLE;
-    } else if (newState === 'off') {
+    } else if (newState === Recording.status.OFF) {
         if (!this.state
             || this.state === 'undefined'
             || this.state === Recording.status.UNAVAILABLE) {
@@ -87,7 +87,7 @@ Recording.prototype.handleJibriPresence = function(jibri) {
 Recording.prototype.setRecordingJibri
     = function(state, callback, errCallback, options = {}) {
 
-        if (state == this.state) {
+        if (state === this.state) {
             errCallback(JitsiRecorderErrors.INVALID_STATE);
         }
 
@@ -123,8 +123,7 @@ Recording.prototype.setRecordingJibri
 
 Recording.prototype.setRecordingJirecon
     = function(state, callback, errCallback) {
-
-        if (state == this.state) {
+        if (state === this.state) {
             errCallback(new Error('Invalid state!'));
         }
 
@@ -136,7 +135,7 @@ Recording.prototype.setRecordingJirecon
                 : Recording.action.STOP,
             mucjid: this.roomjid });
 
-        if (state === 'off') {
+        if (state === Recording.status.OFF) {
             iq.attrs({ rid: this.jireconRid });
         }
 

modules/xmpp/strophe.jingle.js

@@ -50,7 +50,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
         logger.log(`on jingle ${action} from ${fromJid}`, iq);
         let sess = this.sessions[sid];
 
-        if (action != 'session-initiate') {
+        if (action !== 'session-initiate') {
             if (!sess) {
                 ack.attrs({ type: 'error' });
                 ack.c('error', { type: 'cancel' })
@@ -68,7 +68,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
             }
 
             // local jid is not checked
-            if (fromJid != sess.peerjid) {
+            if (fromJid !== sess.peerjid) {
                 logger.warn(
                     'jid mismatch for session id', sid, sess.peerjid, iq);
                 ack.attrs({ type: 'error' });
@@ -188,7 +188,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
 
     terminate(sid, reasonCondition, reasonText) {
         if (this.sessions.hasOwnProperty(sid)) {
-            if (this.sessions[sid].state != 'ended') {
+            if (this.sessions[sid].state !== 'ended') {
                 this.sessions[sid].onTerminated(reasonCondition, reasonText);
             }
             delete this.sessions[sid];
@@ -255,12 +255,12 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                         dict.url += el.attr('host');
                         const port = el.attr('port');
 
-                        if (port && port != '3478') {
+                        if (port && port !== '3478') {
                             dict.url += `:${el.attr('port')}`;
                         }
                         const transport = el.attr('transport');
 
-                        if (transport && transport != 'udp') {
+                        if (transport && transport !== 'udp') {
                             dict.url += `?transport=${transport}`;
                         }
 

modules/xmpp/xmpp.js

@@ -20,7 +20,7 @@ function createConnection(token, bosh = '/http-bind') {
     // Append token as URL param
     if (token) {
         // eslint-disable-next-line no-param-reassign
-        bosh += `${bosh.indexOf('?') == -1 ? '?' : '&'}token=${token}`;
+        bosh += `${bosh.indexOf('?') === -1 ? '?' : '&'}token=${token}`;
     }
 
     return new Strophe.Connection(bosh);
@@ -374,7 +374,7 @@ export default class XMPP extends Listenable {
         if (ev !== null && typeof ev !== 'undefined') {
             const evType = ev.type;
 
-            if (evType == 'beforeunload' || evType == 'unload') {
+            if (evType === 'beforeunload' || evType === 'unload') {
                 // XXX Whatever we said above, synchronous sending is the best
                 // (known) way to properly disconnect from the XMPP server.
                 // Consequently, it may be fine to have the source code and