Browse Source

sdp: add missing colon to findLines calls (#1447)

in order to not match a=msid-somethingelse, a=ridiculous and similar
dev1
Philipp Hancke 4 years ago
parent
commit
f1df5585aa
No account linked to committer's email address
2 changed files with 2 additions and 2 deletions
  1. 1
    1
      modules/RTC/TraceablePeerConnection.js
  2. 1
    1
      modules/xmpp/SDP.js

+ 1
- 1
modules/RTC/TraceablePeerConnection.js View File

804
             mediaLines = remoteSDP.media.filter(mls => SDPUtil.findLine(mls, `a=mid:${mid}`));
804
             mediaLines = remoteSDP.media.filter(mls => SDPUtil.findLine(mls, `a=mid:${mid}`));
805
         } else {
805
         } else {
806
             mediaLines = remoteSDP.media.filter(mls => {
806
             mediaLines = remoteSDP.media.filter(mls => {
807
-                const msid = SDPUtil.findLine(mls, 'a=msid');
807
+                const msid = SDPUtil.findLine(mls, 'a=msid:');
808
 
808
 
809
                 return typeof msid !== 'undefined' && streamId === msid.substring(7).split(' ')[0];
809
                 return typeof msid !== 'undefined' && streamId === msid.substring(7).split(' ')[0];
810
             });
810
             });

+ 1
- 1
modules/xmpp/SDP.js View File

249
                 });
249
                 });
250
             }
250
             }
251
 
251
 
252
-            const ridLines = SDPUtil.findLines(this.media[i], 'a=rid');
252
+            const ridLines = SDPUtil.findLines(this.media[i], 'a=rid:');
253
 
253
 
254
             if (ridLines.length && browser.usesRidsForSimulcast()) {
254
             if (ridLines.length && browser.usesRidsForSimulcast()) {
255
                 // Map a line which looks like "a=rid:2 send" to just
255
                 // Map a line which looks like "a=rid:2 send" to just

Loading…
Cancel
Save