feat(BrowserCapabilities): introduce isChromiumBased

This function helps simplify the code when handling browsers that are pretty
much Chrome in disguise.

modules/RTC/RTCUtils.js

@@ -814,10 +814,7 @@ class RTCUtils extends Listenable {
 
             this.getStreamID = ({ id }) => id;
             this.getTrackID = ({ id }) => id;
-        } else if (browser.isChrome() // this is chrome < 61
-                || browser.isOpera()
-                || browser.isNWJS()
-                || browser.isElectron()
+        } else if (browser.isChromiumBased() // this is chrome < 61
                 || browser.isReactNative()) {
 
             this.RTCPeerConnectionType = RTCPeerConnection;
@@ -946,11 +943,7 @@ class RTCUtils extends Listenable {
     _initPCConstraints(options) {
         if (browser.isFirefox()) {
             this.pcConstraints = {};
-        } else if (browser.isChrome()
-            || browser.isOpera()
-            || browser.isNWJS()
-            || browser.isElectron()
-            || browser.isReactNative()) {
+        } else if (browser.isChromiumBased() || browser.isReactNative()) {
             this.pcConstraints = { optional: [
                 { googHighStartBitrate: 0 },
                 { googPayloadPadding: true },
@@ -1457,12 +1450,8 @@ class RTCUtils extends Listenable {
     isDeviceChangeAvailable(deviceType) {
         return deviceType === 'output' || deviceType === 'audiooutput'
             ? isAudioOutputDeviceChangeAvailable
-            : browser.isChrome()
-                || browser.isFirefox()
-                || browser.isOpera()
-                || browser.isNWJS()
-                || browser.isElectron()
-                || browser.isEdge();
+            : browser.isChromiumBased()
+                || browser.isFirefox() || browser.isEdge();
     }
 
     /**

modules/RTC/TraceablePeerConnection.js

@@ -581,8 +581,7 @@ TraceablePeerConnection.prototype._remoteStreamAdded = function(stream) {
     }
 
     // Bind 'addtrack'/'removetrack' event handlers
-    if (browser.isChrome() || browser.isNWJS()
-        || browser.isElectron() || browser.isEdge()) {
+    if (browser.isChromiumBased() || browser.isEdge()) {
         stream.onaddtrack = event => {
             this._remoteTrackAdded(stream, event.track);
         };

modules/browser/BrowserCapabilities.js

@@ -47,6 +47,25 @@ export default class BrowserCapabilities extends BrowserDetection {
         return !this.isEdge() && !this.isFirefox();
     }
 
+    /**
+     * Checks if the current browser is Chromium based, that is, it's either
+     * Chrome / Chromium or uses it as its engine, but doesn't identify as
+     * Chrome.
+     *
+     * This includes the following browsers:
+     * - Chrome and Chromium
+     * - Other browsers which use the Chrome engine, but are detected as Chrome,
+     *   such as Brave and Vivaldi
+     * - Browsers which are NOT Chrome but use it as their engine, and have
+     *   custom detection code: Opera, Electron and NW.JS
+     */
+    isChromiumBased() {
+        return this.isChrome()
+            || this.isElectron()
+            || this.isNWJS()
+            || this.isOpera();
+    }
+
     /**
      * Checks if current browser is a Safari and a version of Safari that
      * supports native webrtc.
@@ -64,12 +83,9 @@ export default class BrowserCapabilities extends BrowserDetection {
      * @returns {boolean} true if the browser is supported, false otherwise.
      */
     isSupported() {
-        return this.isChrome()
+        return this.isChromiumBased()
             || this.isEdge()
-            || this.isElectron()
             || this.isFirefox()
-            || this.isNWJS()
-            || this.isOpera()
             || this.isReactNative()
             || this.isSafariWithWebrtc();
     }
@@ -81,7 +97,7 @@ export default class BrowserCapabilities extends BrowserDetection {
      * otherwise.
      */
     supportsVideoMuteOnConnInterrupted() {
-        return this.isChrome() || this.isElectron() || this.isReactNative();
+        return this.isChromiumBased() || this.isReactNative();
     }
 
     /**
@@ -132,12 +148,9 @@ export default class BrowserCapabilities extends BrowserDetection {
      * @returns {boolean} true if they are supported, false otherwise.
      */
     supportsRtpStatistics() {
-        return this.isChrome()
+        return this.isChromiumBased()
             || this.isEdge()
-            || this.isElectron()
             || this.isFirefox()
-            || this.isNWJS()
-            || this.isOpera()
             || this.isReactNative()
             || this.isSafariWithWebrtc();
     }
@@ -147,9 +160,7 @@ export default class BrowserCapabilities extends BrowserDetection {
      * candidates through the legacy getStats() API.
      */
     supportsLocalCandidateRttStatistics() {
-        return this.isChrome()
-            || this.isElectron()
-            || this.isReactNative();
+        return this.isChromiumBased() || this.isReactNative();
     }
 
     /**
@@ -192,11 +203,8 @@ export default class BrowserCapabilities extends BrowserDetection {
      * @returns {boolean}
      */
     supportsSimulcast() {
-        return this.isChrome()
-            || this.isFirefox()
-            || this.isElectron()
-            || this.isNWJS()
-            || this.isReactNative();
+        return this.isChromiumBased()
+            || this.isFirefox() || this.isReactNative();
     }
 
     /**