Browse Source

Detail comment

master
Lyubo Marinov 8 years ago
parent
commit
aaf7a38cce
1 changed files with 9 additions and 5 deletions
  1. 9
    5
      react/features/toolbar/components/Toolbar.native.js

+ 9
- 5
react/features/toolbar/components/Toolbar.native.js View File

@@ -112,19 +112,23 @@ class Toolbar extends AbstractToolbar {
112 112
 
113 113
         /* eslint-disable react/jsx-curly-spacing,react/jsx-handler-names */
114 114
 
115
-        // TODO Use an appropriate icon for toggle camera facing mode.
116 115
         return (
117 116
             <View style = { styles.secondaryToolbar }>
118
-                {/*
119
-                  * XXX Temporarily disabled until issues are fixed in
120
-                  * react-native-webrtc.
117
+                {/* FIXME There are multiple issues with the toggling of the
118
+                  * camera facing more. For example, switching from the user
119
+                  * facing camera to the environment facing camera on iOS may be
120
+                  * very slow or may not work at all. On Android the toggling
121
+                  * either works or does not. The causes of the various problems
122
+                  * have been identified to lie within either
123
+                  * react-native-webrtc or Google's native WebRTC API.
124
+                  *
121 125
                 <ToolbarButton
122 126
                     iconName = 'switch-camera'
123 127
                     iconStyle = { iconStyle }
124 128
                     onClick = { this._toggleCameraFacingMode }
125 129
                     style = { style }
126 130
                     underlayColor = { underlayColor } />
127
-                */}
131
+                  */}
128 132
                 <ToolbarButton
129 133
                     iconName = {
130 134
                         this.props._locked ? 'security-locked' : 'security'

Loading…
Cancel
Save