Browse Source

fix(suboptimal-browser): remove inserting of app name in notification

This prevents inserting any user overridden APP_NAME
values into html. A new translation key is being used
to immediately stop non-english languages from using the
problematic string.

Also tweaked the copy to remove the "eer" and fix
some grammar.
j8
Leonard Kim 6 years ago
parent
commit
e8eb7e1e1f
2 changed files with 3 additions and 6 deletions
  1. 1
    1
      lang/main.json
  2. 2
    5
      react/features/conference/functions.js

+ 1
- 1
lang/main.json View File

@@ -429,7 +429,7 @@
429 429
         "somebody": "Somebody",
430 430
         "startSilentTitle": "You joined with no audio output!",
431 431
         "startSilentDescription": "Rejoin the meeting to enable audio",
432
-        "suboptimalExperienceDescription": "Eer... we are afraid your experience with {{appName}} isn't going to be that great here. We are looking for ways to improve this but, until then, please try using one of the <a href='static/recommendedBrowsers.html' target='_blank'>fully supported browsers</a>.",
432
+        "suboptimalBrowserWarning": "We are afraid your meeting experience isn't going to be that great here. We are looking for ways to improve this, but until then please try using one of the <a href='static/recommendedBrowsers.html' target='_blank'>fully supported browsers</a>.",
433 433
         "suboptimalExperienceTitle": "Browser Warning",
434 434
         "unmute": "Unmute",
435 435
         "newDeviceCameraTitle": "New camera detected",

+ 2
- 5
react/features/conference/functions.js View File

@@ -2,7 +2,6 @@ import { translateToHTML } from '../base/i18n';
2 2
 import { isSuboptimalBrowser } from '../base/environment';
3 3
 import { toState } from '../base/redux';
4 4
 
5
-import { getName } from '../app';
6 5
 import {
7 6
     areThereNotifications,
8 7
     showWarningNotification
@@ -24,10 +23,8 @@ export function maybeShowSuboptimalExperienceNotification(dispatch, t) {
24 23
                     titleKey: 'notify.suboptimalExperienceTitle',
25 24
                     description: translateToHTML(
26 25
                         t,
27
-                        'notify.suboptimalExperienceDescription',
28
-                        {
29
-                            appName: getName()
30
-                        })
26
+                        'notify.suboptimalBrowserWarning'
27
+                    )
31 28
                 }
32 29
             )
33 30
         );

Loading…
Cancel
Save