Procházet zdrojové kódy

ref: remove connectivity issues indication for remote participants

It's been considered too disruptive and will often misfire especially
if there are issues with the data channels.
master
paweldomas před 5 roky
rodič
revize
01e36e1c56

+ 0
- 5
css/_videolayout_default.scss Zobrazit soubor

@@ -573,11 +573,6 @@
573 573
     filter: grayscale(.5) opacity(0.8);
574 574
 }
575 575
 
576
-.remoteVideoProblemFilter {
577
-    -webkit-filter: grayscale(100%);
578
-    filter: grayscale(100%);
579
-}
580
-
581 576
 .videoThumbnailProblemFilter {
582 577
     -webkit-filter: grayscale(100%);
583 578
     filter: grayscale(100%);

+ 1
- 2
lang/main.json Zobrazit soubor

@@ -80,8 +80,7 @@
80 80
         "FETCH_SESSION_ID": "Obtaining session-id...",
81 81
         "GET_SESSION_ID_ERROR": "Get session-id error: {{code}}",
82 82
         "GOT_SESSION_ID": "Obtaining session-id... Done",
83
-        "LOW_BANDWIDTH": "Video for {{displayName}} has been turned off to save bandwidth",
84
-        "USER_CONNECTION_INTERRUPTED": "{{displayName}} is having connectivity issues..."
83
+        "LOW_BANDWIDTH": "Video for {{displayName}} has been turned off to save bandwidth"
85 84
     },
86 85
     "connectionindicator": {
87 86
         "address": "Address:",

+ 3
- 21
modules/UI/videolayout/LargeVideoManager.js Zobrazit soubor

@@ -237,17 +237,8 @@ export default class LargeVideoManager {
237 237
                 this.updateLargeVideoAudioLevel(0);
238 238
             }
239 239
 
240
-            const isConnectionInterrupted
241
-                = APP.conference.getParticipantConnectionStatus(id)
242
-                    === JitsiParticipantConnectionStatus.INTERRUPTED;
243
-            let messageKey = null;
244
-
245
-            if (isConnectionInterrupted) {
246
-                messageKey = 'connection.USER_CONNECTION_INTERRUPTED';
247
-            } else if (connectionStatus
248
-                    === JitsiParticipantConnectionStatus.INACTIVE) {
249
-                messageKey = 'connection.LOW_BANDWIDTH';
250
-            }
240
+            const messageKey
241
+                = connectionStatus === JitsiParticipantConnectionStatus.INACTIVE ? 'connection.LOW_BANDWIDTH' : null;
251 242
 
252 243
             // Do not show connection status message in the audio only mode,
253 244
             // because it's based on the video playback status.
@@ -255,7 +246,6 @@ export default class LargeVideoManager {
255 246
 
256 247
             this.updateParticipantConnStatusIndication(
257 248
                     id,
258
-                    !overrideAndHide && isConnectionInterrupted,
259 249
                     !overrideAndHide && messageKey);
260 250
 
261 251
             // Change the participant id the presence label is listening to.
@@ -281,20 +271,12 @@ export default class LargeVideoManager {
281 271
      * shown on the large video area.
282 272
      *
283 273
      * @param {string} id the id of remote participant(MUC nickname)
284
-     * @param {boolean} showProblemsIndication
285 274
      * @param {string|null} messageKey the i18n key of the message which will be
286 275
      * displayed on the large video or <tt>null</tt> to hide it.
287 276
      *
288 277
      * @private
289 278
      */
290
-    updateParticipantConnStatusIndication(
291
-            id,
292
-            showProblemsIndication,
293
-            messageKey) {
294
-        // Apply grey filter on the large video
295
-        this.videoContainer.showRemoteConnectionProblemIndicator(
296
-            showProblemsIndication);
297
-
279
+    updateParticipantConnStatusIndication(id, messageKey) {
298 280
         if (messageKey) {
299 281
             // Get user's display name
300 282
             const displayName

+ 0
- 25
modules/UI/videolayout/VideoContainer.js Zobrazit soubor

@@ -19,15 +19,6 @@ export const VIDEO_CONTAINER_TYPE = 'camera';
19 19
 
20 20
 const FADE_DURATION_MS = 300;
21 21
 
22
-/**
23
- * The CSS class used to add a filter effect on the large video when there is
24
- * a problem with remote video.
25
- *
26
- * @private
27
- * @type {string}
28
- */
29
-const REMOTE_PROBLEM_FILTER_CLASS = 'remoteVideoProblemFilter';
30
-
31 22
 /**
32 23
  * Returns an array of the video dimensions, so that it keeps it's aspect
33 24
  * ratio and fits available area with it's larger dimension. This method
@@ -555,20 +546,6 @@ export class VideoContainer extends LargeContainer {
555 546
         APP.API.notifyLargeVideoVisibilityChanged(show);
556 547
     }
557 548
 
558
-    /**
559
-     * Indicates that the remote user who is currently displayed by this video
560
-     * container is having connectivity issues.
561
-     *
562
-     * @param {boolean} show <tt>true</tt> to show or <tt>false</tt> to hide
563
-     * the indication.
564
-     */
565
-    showRemoteConnectionProblemIndicator(show) {
566
-        this.$video.toggleClass(REMOTE_PROBLEM_FILTER_CLASS, show);
567
-        this.$avatar.toggleClass(REMOTE_PROBLEM_FILTER_CLASS, show);
568
-        this._updateBackground();
569
-    }
570
-
571
-
572 549
     /**
573 550
      * We are doing fadeOut/fadeIn animations on parent div which wraps
574 551
      * largeVideo, because when Temasys plugin is in use it replaces
@@ -665,8 +642,6 @@ export class VideoContainer extends LargeContainer {
665 642
                     && this.localFlipX
666 643
                 }
667 644
                 orientationFit = { this._backgroundOrientation }
668
-                showRemoteProblemFilter
669
-                    = { this.$video.hasClass(REMOTE_PROBLEM_FILTER_CLASS) }
670 645
                 videoElement = { this.$video && this.$video[0] }
671 646
                 videoTrack = { this.stream } />,
672 647
             document.getElementById('largeVideoBackgroundContainer')

+ 0
- 3
react/features/base/participants/components/ParticipantView.native.js Zobrazit soubor

@@ -144,9 +144,6 @@ class ParticipantView extends Component<Props> {
144 144
         case JitsiParticipantConnectionStatus.INACTIVE:
145 145
             messageKey = 'connection.LOW_BANDWIDTH';
146 146
             break;
147
-        case JitsiParticipantConnectionStatus.INTERRUPTED:
148
-            messageKey = 'connection.USER_CONNECTION_INTERRUPTED';
149
-            break;
150 147
         default:
151 148
             return null;
152 149
         }

+ 2
- 11
react/features/large-video/components/LargeVideoBackground.web.js Zobrazit soubor

@@ -43,12 +43,6 @@ type Props = {
43 43
      */
44 44
     orientationFit: string,
45 45
 
46
-    /**
47
-     * Whether or not to display a filter on the video to visually indicate a
48
-     * problem with the video being displayed.
49
-     */
50
-    showRemoteProblemFilter: boolean,
51
-
52 46
     /**
53 47
      * The video stream to display.
54 48
      */
@@ -131,12 +125,9 @@ export class LargeVideoBackground extends Component<Props> {
131 125
     render() {
132 126
         const {
133 127
             hidden,
134
-            mirror,
135
-            showRemoteProblemFilter
128
+            mirror
136 129
         } = this.props;
137
-        const classNames = `large-video-background ${mirror ? 'flip-x' : ''} ${
138
-            hidden ? 'invisible' : ''} ${
139
-            showRemoteProblemFilter ? 'remoteVideoProblemFilter' : ''}`;
130
+        const classNames = `large-video-background ${mirror ? 'flip-x' : ''} ${hidden ? 'invisible' : ''}`;
140 131
 
141 132
         return (
142 133
             <div className = { classNames }>

Načítá se…
Zrušit
Uložit