Selaa lähdekoodia

ref: remove connectivity issues indication for remote participants

It's been considered too disruptive and will often misfire especially
if there are issues with the data channels.
master
paweldomas 5 vuotta sitten
vanhempi
commit
01e36e1c56

+ 0
- 5
css/_videolayout_default.scss Näytä tiedosto

573
     filter: grayscale(.5) opacity(0.8);
573
     filter: grayscale(.5) opacity(0.8);
574
 }
574
 }
575
 
575
 
576
-.remoteVideoProblemFilter {
577
-    -webkit-filter: grayscale(100%);
578
-    filter: grayscale(100%);
579
-}
580
-
581
 .videoThumbnailProblemFilter {
576
 .videoThumbnailProblemFilter {
582
     -webkit-filter: grayscale(100%);
577
     -webkit-filter: grayscale(100%);
583
     filter: grayscale(100%);
578
     filter: grayscale(100%);

+ 1
- 2
lang/main.json Näytä tiedosto

80
         "FETCH_SESSION_ID": "Obtaining session-id...",
80
         "FETCH_SESSION_ID": "Obtaining session-id...",
81
         "GET_SESSION_ID_ERROR": "Get session-id error: {{code}}",
81
         "GET_SESSION_ID_ERROR": "Get session-id error: {{code}}",
82
         "GOT_SESSION_ID": "Obtaining session-id... Done",
82
         "GOT_SESSION_ID": "Obtaining session-id... Done",
83
-        "LOW_BANDWIDTH": "Video for {{displayName}} has been turned off to save bandwidth",
84
-        "USER_CONNECTION_INTERRUPTED": "{{displayName}} is having connectivity issues..."
83
+        "LOW_BANDWIDTH": "Video for {{displayName}} has been turned off to save bandwidth"
85
     },
84
     },
86
     "connectionindicator": {
85
     "connectionindicator": {
87
         "address": "Address:",
86
         "address": "Address:",

+ 3
- 21
modules/UI/videolayout/LargeVideoManager.js Näytä tiedosto

237
                 this.updateLargeVideoAudioLevel(0);
237
                 this.updateLargeVideoAudioLevel(0);
238
             }
238
             }
239
 
239
 
240
-            const isConnectionInterrupted
241
-                = APP.conference.getParticipantConnectionStatus(id)
242
-                    === JitsiParticipantConnectionStatus.INTERRUPTED;
243
-            let messageKey = null;
244
-
245
-            if (isConnectionInterrupted) {
246
-                messageKey = 'connection.USER_CONNECTION_INTERRUPTED';
247
-            } else if (connectionStatus
248
-                    === JitsiParticipantConnectionStatus.INACTIVE) {
249
-                messageKey = 'connection.LOW_BANDWIDTH';
250
-            }
240
+            const messageKey
241
+                = connectionStatus === JitsiParticipantConnectionStatus.INACTIVE ? 'connection.LOW_BANDWIDTH' : null;
251
 
242
 
252
             // Do not show connection status message in the audio only mode,
243
             // Do not show connection status message in the audio only mode,
253
             // because it's based on the video playback status.
244
             // because it's based on the video playback status.
255
 
246
 
256
             this.updateParticipantConnStatusIndication(
247
             this.updateParticipantConnStatusIndication(
257
                     id,
248
                     id,
258
-                    !overrideAndHide && isConnectionInterrupted,
259
                     !overrideAndHide && messageKey);
249
                     !overrideAndHide && messageKey);
260
 
250
 
261
             // Change the participant id the presence label is listening to.
251
             // Change the participant id the presence label is listening to.
281
      * shown on the large video area.
271
      * shown on the large video area.
282
      *
272
      *
283
      * @param {string} id the id of remote participant(MUC nickname)
273
      * @param {string} id the id of remote participant(MUC nickname)
284
-     * @param {boolean} showProblemsIndication
285
      * @param {string|null} messageKey the i18n key of the message which will be
274
      * @param {string|null} messageKey the i18n key of the message which will be
286
      * displayed on the large video or <tt>null</tt> to hide it.
275
      * displayed on the large video or <tt>null</tt> to hide it.
287
      *
276
      *
288
      * @private
277
      * @private
289
      */
278
      */
290
-    updateParticipantConnStatusIndication(
291
-            id,
292
-            showProblemsIndication,
293
-            messageKey) {
294
-        // Apply grey filter on the large video
295
-        this.videoContainer.showRemoteConnectionProblemIndicator(
296
-            showProblemsIndication);
297
-
279
+    updateParticipantConnStatusIndication(id, messageKey) {
298
         if (messageKey) {
280
         if (messageKey) {
299
             // Get user's display name
281
             // Get user's display name
300
             const displayName
282
             const displayName

+ 0
- 25
modules/UI/videolayout/VideoContainer.js Näytä tiedosto

19
 
19
 
20
 const FADE_DURATION_MS = 300;
20
 const FADE_DURATION_MS = 300;
21
 
21
 
22
-/**
23
- * The CSS class used to add a filter effect on the large video when there is
24
- * a problem with remote video.
25
- *
26
- * @private
27
- * @type {string}
28
- */
29
-const REMOTE_PROBLEM_FILTER_CLASS = 'remoteVideoProblemFilter';
30
-
31
 /**
22
 /**
32
  * Returns an array of the video dimensions, so that it keeps it's aspect
23
  * Returns an array of the video dimensions, so that it keeps it's aspect
33
  * ratio and fits available area with it's larger dimension. This method
24
  * ratio and fits available area with it's larger dimension. This method
555
         APP.API.notifyLargeVideoVisibilityChanged(show);
546
         APP.API.notifyLargeVideoVisibilityChanged(show);
556
     }
547
     }
557
 
548
 
558
-    /**
559
-     * Indicates that the remote user who is currently displayed by this video
560
-     * container is having connectivity issues.
561
-     *
562
-     * @param {boolean} show <tt>true</tt> to show or <tt>false</tt> to hide
563
-     * the indication.
564
-     */
565
-    showRemoteConnectionProblemIndicator(show) {
566
-        this.$video.toggleClass(REMOTE_PROBLEM_FILTER_CLASS, show);
567
-        this.$avatar.toggleClass(REMOTE_PROBLEM_FILTER_CLASS, show);
568
-        this._updateBackground();
569
-    }
570
-
571
-
572
     /**
549
     /**
573
      * We are doing fadeOut/fadeIn animations on parent div which wraps
550
      * We are doing fadeOut/fadeIn animations on parent div which wraps
574
      * largeVideo, because when Temasys plugin is in use it replaces
551
      * largeVideo, because when Temasys plugin is in use it replaces
665
                     && this.localFlipX
642
                     && this.localFlipX
666
                 }
643
                 }
667
                 orientationFit = { this._backgroundOrientation }
644
                 orientationFit = { this._backgroundOrientation }
668
-                showRemoteProblemFilter
669
-                    = { this.$video.hasClass(REMOTE_PROBLEM_FILTER_CLASS) }
670
                 videoElement = { this.$video && this.$video[0] }
645
                 videoElement = { this.$video && this.$video[0] }
671
                 videoTrack = { this.stream } />,
646
                 videoTrack = { this.stream } />,
672
             document.getElementById('largeVideoBackgroundContainer')
647
             document.getElementById('largeVideoBackgroundContainer')

+ 0
- 3
react/features/base/participants/components/ParticipantView.native.js Näytä tiedosto

144
         case JitsiParticipantConnectionStatus.INACTIVE:
144
         case JitsiParticipantConnectionStatus.INACTIVE:
145
             messageKey = 'connection.LOW_BANDWIDTH';
145
             messageKey = 'connection.LOW_BANDWIDTH';
146
             break;
146
             break;
147
-        case JitsiParticipantConnectionStatus.INTERRUPTED:
148
-            messageKey = 'connection.USER_CONNECTION_INTERRUPTED';
149
-            break;
150
         default:
147
         default:
151
             return null;
148
             return null;
152
         }
149
         }

+ 2
- 11
react/features/large-video/components/LargeVideoBackground.web.js Näytä tiedosto

43
      */
43
      */
44
     orientationFit: string,
44
     orientationFit: string,
45
 
45
 
46
-    /**
47
-     * Whether or not to display a filter on the video to visually indicate a
48
-     * problem with the video being displayed.
49
-     */
50
-    showRemoteProblemFilter: boolean,
51
-
52
     /**
46
     /**
53
      * The video stream to display.
47
      * The video stream to display.
54
      */
48
      */
131
     render() {
125
     render() {
132
         const {
126
         const {
133
             hidden,
127
             hidden,
134
-            mirror,
135
-            showRemoteProblemFilter
128
+            mirror
136
         } = this.props;
129
         } = this.props;
137
-        const classNames = `large-video-background ${mirror ? 'flip-x' : ''} ${
138
-            hidden ? 'invisible' : ''} ${
139
-            showRemoteProblemFilter ? 'remoteVideoProblemFilter' : ''}`;
130
+        const classNames = `large-video-background ${mirror ? 'flip-x' : ''} ${hidden ? 'invisible' : ''}`;
140
 
131
 
141
         return (
132
         return (
142
             <div className = { classNames }>
133
             <div className = { classNames }>

Loading…
Peruuta
Tallenna