Przeglądaj źródła

fix(audio-levels) check if local stats are supported before starting stats collection.

master
Jaya Allamsetty 2 lat temu
rodzic
commit
c8d76d4ad7

+ 2
- 1
JitsiConference.js Wyświetl plik

@@ -35,6 +35,7 @@ import RecordingManager from './modules/recording/RecordingManager';
35 35
 import Settings from './modules/settings/Settings';
36 36
 import AudioOutputProblemDetector from './modules/statistics/AudioOutputProblemDetector';
37 37
 import AvgRTPStatsReporter from './modules/statistics/AvgRTPStatsReporter';
38
+import LocalStatsCollector from './modules/statistics/LocalStatsCollector';
38 39
 import SpeakerStatsCollector from './modules/statistics/SpeakerStatsCollector';
39 40
 import Statistics from './modules/statistics/statistics';
40 41
 import Transcriber from './modules/transcription/transcriber';
@@ -531,7 +532,7 @@ JitsiConference.prototype._init = function(options = {}) {
531 532
     }
532 533
 
533 534
     // Generates events based on no audio input detector.
534
-    if (config.enableNoAudioDetection && !config.disableAudioLevels) {
535
+    if (config.enableNoAudioDetection && !config.disableAudioLevels && LocalStatsCollector.isLocalStatsSupported()) {
535 536
         this._noAudioSignalDetection = new NoAudioSignalDetection(this);
536 537
         this._noAudioSignalDetection.on(DetectionEvents.NO_AUDIO_INPUT, () => {
537 538
             this.eventEmitter.emit(JitsiConferenceEvents.NO_AUDIO_INPUT);

+ 2
- 3
JitsiMeetJS.ts Wyświetl plik

@@ -307,7 +307,7 @@ export default {
307 307
                         'success',
308 308
                         getAnalyticsAttributesFromOptions(restOptions)));
309 309
 
310
-                if (!RTC.options.disableAudioLevels) {
310
+                if (this.isCollectingLocalStats()) {
311 311
                     for (let i = 0; i < tracks.length; i++) {
312 312
                         const track = tracks[i];
313 313
 
@@ -484,8 +484,7 @@ export default {
484 484
      * @param {boolean} True if stats are being collected for local tracks.
485 485
      */
486 486
     isCollectingLocalStats() {
487
-        return Statistics.audioLevelsEnabled
488
-            && LocalStatsCollector.isLocalStatsSupported();
487
+        return Statistics.audioLevelsEnabled && LocalStatsCollector.isLocalStatsSupported();
489 488
     },
490 489
 
491 490
     /**

+ 1
- 1
modules/statistics/LocalStatsCollector.js Wyświetl plik

@@ -143,7 +143,7 @@ LocalStatsCollector.prototype.stop = function() {
143 143
  * @returns {boolean}
144 144
  */
145 145
 LocalStatsCollector.isLocalStatsSupported = function() {
146
-    return Boolean(window.AudioContext);
146
+    return Boolean(window?.AudioContext);
147 147
 };
148 148
 
149 149
 /**

Ładowanie…
Anuluj
Zapisz