Browse Source

address code review

dev1
Andrei Gavrilescu 6 years ago
parent
commit
e2d029e5c7
2 changed files with 1 additions and 6 deletions
  1. 1
    4
      JitsiConference.js
  2. 0
    2
      webpack.config.js

+ 1
- 4
JitsiConference.js View File

@@ -379,7 +379,6 @@ JitsiConference.prototype._init = function(options = {}) {
379 379
         // based detection.
380 380
         if (config.createVADProcessor) {
381 381
             logger.info('Using VAD detection for generating talk while muted events');
382
-            // eslint-disable-next-line no-new
383 382
             this._talkWhileMutedDetection = new VADTalkMutedDetection(this, config.createVADProcessor);
384 383
             this._talkWhileMutedDetection.on(DetectionEvents.VAD_TALK_WHILE_MUTED, () =>
385 384
                 this.eventEmitter.emit(JitsiConferenceEvents.TALK_WHILE_MUTED));
@@ -392,10 +391,8 @@ JitsiConference.prototype._init = function(options = {}) {
392 391
     }
393 392
 
394 393
     // Generates events based on no audio input detector.
395
-    // eslint-disable-next-line
396 394
     if (config.enableNoAudioDetection) {
397
-        // eslint-disable-next-line no-new
398
-        new NoAudioSignalDetection(this, () =>
395
+        this._noAudioSignalDetection = new NoAudioSignalDetection(this, () =>
399 396
             this.eventEmitter.emit(JitsiConferenceEvents.NO_AUDIO_INPUT));
400 397
     }
401 398
 

+ 0
- 2
webpack.config.js View File

@@ -61,10 +61,8 @@ const config = {
61 61
         concatenateModules: minimize
62 62
     },
63 63
     output: {
64
-        // eslint-disable-next-line
65 64
         filename: `[name]${minimize ? '.min' : ''}.js`,
66 65
         path: process.cwd(),
67
-        // eslint-disable-next-line
68 66
         sourceMapFilename: `[name].${minimize ? 'min' : 'js'}.map`
69 67
     },
70 68
     performance: {

Loading…
Cancel
Save