Browse Source

tpc: apply a=setup: actpass fix also on mobile

dev1
Saúl Ibarra Corretgé 6 years ago
parent
commit
e5e49457d2
1 changed files with 4 additions and 4 deletions
  1. 4
    4
      modules/RTC/TraceablePeerConnection.js

+ 4
- 4
modules/RTC/TraceablePeerConnection.js View File

@@ -2104,7 +2104,7 @@ TraceablePeerConnection.prototype.close = function() {
2104 2104
  * Modifies the values of the setup attributes (defined by
2105 2105
  * {@link http://tools.ietf.org/html/rfc4145#section-4}) of a specific SDP
2106 2106
  * answer in order to overcome a delay of 1 second in the connection
2107
- * establishment between Chrome and Videobridge.
2107
+ * establishment between some devices and Videobridge.
2108 2108
  *
2109 2109
  * @param {SDP} offer - the SDP offer to which the specified SDP answer is
2110 2110
  * being prepared to respond
@@ -2112,13 +2112,13 @@ TraceablePeerConnection.prototype.close = function() {
2112 2112
  * @private
2113 2113
  */
2114 2114
 const _fixAnswerRFC4145Setup = function(offer, answer) {
2115
-    if (!browser.isChrome()) {
2115
+    if (!(browser.isChromiumBased() || browser.isReactNative())) {
2116 2116
         // It looks like Firefox doesn't agree with the fix (at least in its
2117 2117
         // current implementation) because it effectively remains active even
2118 2118
         // after we tell it to become passive. Apart from Firefox which I tested
2119 2119
         // after the fix was deployed, I tested Chrome only. In order to prevent
2120
-        // issues with other browsers, limit the fix to Chrome for the time
2121
-        // being.
2120
+        // issues with other browsers, limit the fix to known devices for the
2121
+        // time being.
2122 2122
         return;
2123 2123
     }
2124 2124
 

Loading…
Cancel
Save